chore: merge design-audit remediation changes by BigSimmo · Pull Request #832 · BigSimmo/Database

BigSimmo · 2026-07-18T07:39:01Z

Scope: applies design-audit remediation merge commit (no-op on unresolved items).

Summary by CodeRabbit

New Features
- Updated the dashboard title to “Clinical KB.”
- Improved search results presentation, including clearer “also matches” placement and more consistent unavailable-answer messaging.
- Improved mobile and full-screen search navigation behavior.
Bug Fixes
- Improved presentation workflow search handling for query parameters.
- Enhanced text-search performance across document facts.
- Refined forms-mode results to avoid displaying unsupported pathway information.
Documentation
- Updated sitemap route listings and presentation redirect documentation.

supabase · 2026-07-18T07:39:08Z

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

coderabbitai · 2026-07-18T07:39:35Z

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 7d34fb2a-25e6-4a01-a711-e421c4884cfa

📥 Commits

Reviewing files that changed from the base of the PR and between ecb5855 and 546e26e.

📒 Files selected for processing (20)

docs/site-map.md
playwright.config.ts
scripts/generate-site-map.ts
src/app/differentials/presentations/route.ts
src/app/page.tsx
src/components/ClinicalDashboard.tsx
src/components/clinical-dashboard/master-search-header.tsx
src/components/services/services-navigator-page.tsx
src/lib/rag-candidate-sources.ts
src/lib/rag.ts
supabase/drift-manifest.json
supabase/migrations/20260714180000_patch_rag_and_corrector_scalability.sql
supabase/migrations/20260714190000_document_table_facts_trgm_idx.sql
tests/audit-content-services-regressions.test.ts
tests/audit-navigation-auth-regressions.test.ts
tests/site-map.test.ts
tests/supabase-schema.test.ts
tests/ui-accessibility.spec.ts
tests/ui-smoke.spec.ts
tests/ui-tools.spec.ts

📝 Walkthrough

Walkthrough

This change updates sitemap and redirect contracts, search query handling, dashboard and services rendering, RAG RPC orchestration, Playwright behavior, and Supabase search schema migrations with corresponding regression-test expectations.

Changes

Search and route contracts

Layer / File(s)	Summary
Route and sitemap contracts `docs/site-map.md`, `scripts/generate-site-map.ts`, `src/app/differentials/...`, `src/app/page.tsx`, `tests/site-map.test.ts`	Factsheet routes are removed from sitemap descriptions, presentation redirects use `[workflow-slug]`, query fallback handling is simplified, and homepage search parameters are explicitly typed.

Dashboard and services UI

Layer / File(s)	Summary
Dashboard search interactions `src/components/ClinicalDashboard.tsx`, `src/components/clinical-dashboard/...`, `playwright.config.ts`, `tests/audit-navigation-auth-regressions.test.ts`, `tests/ui-*.spec.ts`	Dashboard error and also-matches rendering, mode-menu behavior, fullscreen sizing, reduced-motion configuration, authorization assertions, and “Clinical KB” heading expectations are updated.
Services and forms rendering `src/components/services/...`, `tests/audit-content-services-regressions.test.ts`, `tests/ui-tools.spec.ts`	Also-matches content moves into the results header, the right rail remounts by selection bucket, and form/pathway/source-link and mobile transition assertions are revised.

RAG and database

Layer / File(s)	Summary
RAG retrieval orchestration `src/lib/rag-candidate-sources.ts`, `src/lib/rag.ts`	Retrieval RPCs use direct calls and exported error typing; classifier fallback, chunk loading, and answer coalescing remove abort and observability plumbing.
Supabase search schema `supabase/migrations/*`, `supabase/drift-manifest.json`, `tests/supabase-schema.test.ts`	Title-word trigger predicates and schema metadata are updated, a document-table-facts trigram index is created, and schema hardening expectations follow the migration changes.

Estimated code review effort: 4 (Complex) | ~45 minutes

Possibly related PRs

BigSimmo/Database#806: Overlaps on sitemap redirects, reduced-motion configuration, and the same RAG/corrector Supabase migrations.
BigSimmo/Database#809: Directly overlaps with RAG RPC, cancellation, and abort-signal handling changes.
BigSimmo/Database#812: Modifies the same dashboard error-state and UniversalSearchAlsoMatches rendering logic.

Suggested labels: codex

Suggested reviewers: copilot, cursoragent

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description is far too sparse and does not fill the required Summary, Verification, or Risk and rollout sections.	Add the template sections with a summary, verification checklist results, and any relevant risk/rollback notes.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title is concise and correctly summarizes the design-audit remediation merge.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch codex/design-audit-merge-main-20260718-safe

_{Comment @coderabbitai help to get the list of available commands.}

…sign-audit-merge-main-20260718-safe

github-actions · 2026-07-18T07:41:04Z

CI triage

CI failed on this PR. Automated classification of the 6 failed job(s):

Static PR checks — needs investigation: inspect the failing step and uploaded diagnostics; rerun only after classifying the cause.
Production UI — needs investigation: inspect the failing step and uploaded diagnostics; rerun only after classifying the cause.
Unit coverage — needs investigation: inspect the failing step and uploaded diagnostics; rerun only after classifying the cause.
Build — needs investigation: inspect the failing step and uploaded diagnostics; rerun only after classifying the cause.
Advisory UI — needs investigation: inspect the failing step and uploaded diagnostics; rerun only after classifying the cause.
PR required — needs investigation: inspect the failing step and uploaded diagnostics; rerun only after classifying the cause.

Compared with main CI run #3205 (success).

Classification is evidence routing, not permission to ignore a failure. Exact quarantined Playwright identities remain governed by the flake ledger.

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/components/DocumentViewer.tsx`:
- Around line 140-162: Remove the duplicate PdfCanvasViewer, NativePdfEmbed, and
PdfPreviewLoading declarations from the added block in DocumentViewer.tsx.
Retain the existing shared declarations from the earlier block and leave their
usage unchanged so each symbol is defined only once.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: f28490ec-68fe-4b31-9db0-5e287ac4ddc9

📥 Commits

Reviewing files that changed from the base of the PR and between bf9534c and ecb5855.

📒 Files selected for processing (1)

src/components/DocumentViewer.tsx

…260718-safe' into codex/design-audit-merge-main-20260718-safe

* fix: stop Escape focus restore from closing the app-mode menu Scope dismiss deferred a focus restore onto the answer-options trigger. When a mode-menu open landed in the same frame window, that restore stole focus, blur-dismissed the menu, and flaked the Documents mode switch in Production UI CI. Skip restore when the mode menu is open or focus already moved, and wait for the scope popover to hide before opening the menu. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com> * fix(test): fail closed when scope popover does not dismiss Only wait for the scope popover when it is visible, and let that wait throw if dismissal times out so the mode-menu open cannot recreate the Escape focus-restore race. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com> --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>

A merge left PdfCanvasViewer/NativePdfEmbed/PdfPreviewLoading declared twice in DocumentViewer, which broke typecheck and the production build. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>

BigSimmo added 2 commits July 18, 2026 15:26

perf: lazy-load document pdf viewer

ecb5855

chore: merge design-audit remediation changes

b34d6aa

Merge remote-tracking branch 'refs/remotes/origin/main' into codex/de…

ce1a0d0

…sign-audit-merge-main-20260718-safe

coderabbitai Bot reviewed Jul 18, 2026

View reviewed changes

Comment thread src/components/DocumentViewer.tsx

BigSimmo and others added 4 commits July 18, 2026 15:42

Merge remote-tracking branch 'origin/codex/design-audit-merge-main-20…

35cdb0b

…260718-safe' into codex/design-audit-merge-main-20260718-safe

Merge branch 'main' into codex/design-audit-merge-main-20260718-safe

ab5972f

fix: remove duplicate lazy PDF viewer declarations

546e26e

A merge left PdfCanvasViewer/NativePdfEmbed/PdfPreviewLoading declared twice in DocumentViewer, which broke typecheck and the production build. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>

BigSimmo closed this Jul 18, 2026

This was referenced Jul 18, 2026

fix: restore drift manifest metadata to unblock design-audit merge #849

Closed

fix: safely integrate design-audit remediations #859

Merged

chore: align 51278 merge regression tests with current contracts #860

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: merge design-audit remediation changes#832

chore: merge design-audit remediation changes#832
BigSimmo wants to merge 7 commits into
mainfrom
codex/design-audit-merge-main-20260718-safe

BigSimmo commented Jul 18, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

supabase Bot commented Jul 18, 2026

Uh oh!

coderabbitai Bot commented Jul 18, 2026 •

edited

Loading

Review failed

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

github-actions Bot commented Jul 18, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

BigSimmo commented Jul 18, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

supabase Bot commented Jul 18, 2026

Uh oh!

coderabbitai Bot commented Jul 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

github-actions Bot commented Jul 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CI triage

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

BigSimmo commented Jul 18, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jul 18, 2026 •

edited

Loading

github-actions Bot commented Jul 18, 2026 •

edited

Loading